Bulk PDO and mysqli grammar fixes - #5712
Conversation
kamil-tekiela
changed the title
1fc24c0 to
963c166
Compare
jordikroon
left a comment
jordikroon
left a comment
There was a problem hiding this comment.
Mostly small nits. Other than those LGTM.
| named properties in the class | ||
| </para></listitem> | ||
| <listitem><para> | ||
| <listitem><simpara> |
There was a problem hiding this comment.
Should I do it in this PR or in a separate PR? This will create a lot of churn if I have to indent all of them now.
There was a problem hiding this comment.
It's fine if you do it in this PR. Unless someone objects, but will review the commit individually
There was a problem hiding this comment.
If you mean if it's trivial. It's not so I leave it up to you. I don't consider it blocking.
There was a problem hiding this comment.
CS complained about 8 paras, but there were 9. I hope I didn't break anything.
There was a problem hiding this comment.
If it did break, it wouldn't have build in GH Actions. So all good it seems.
There was a problem hiding this comment.
Can I merge it then?
| Gets an attribute of the statement. Currently, no generic attributes exist but only driver specific: | ||
| <itemizedlist> | ||
| <listitem><para><literal>PDO::ATTR_CURSOR_NAME</literal> | ||
| <listitem><simpara><literal>PDO::ATTR_CURSOR_NAME</literal> |
There was a problem hiding this comment.
Same here. It's even worse. Though this was already like this before.
| Sets an attribute on the statement. Currently, no generic attributes are set but only driver specific: | ||
| <itemizedlist> | ||
| <listitem><para><literal>PDO::ATTR_CURSOR_NAME</literal> | ||
| <listitem><simpara><literal>PDO::ATTR_CURSOR_NAME</literal> |
| </term> | ||
| <listitem> | ||
| <para> | ||
| Defines DSN alias. See <methodname>PDO::__construct</methodname> for |
There was a problem hiding this comment.
For some reason docbook-cs didn't catch this. Will have to check this myself. But I will not bother you with it.
There was a problem hiding this comment.
Do you mean the para to simpara here? Is it ok to change it?
12d52b2 to
a8f7a0b
Compare
php/doc-en@1cc1b81 「Bulk PDO and mysqli grammar fixes」(php/doc-en#5712) への追随。 原文側の変更は (a) 英文法・冠詞・タイポの修正と (b) `<para>` から `<simpara>` への変換で、(a) は訳文に影響しないため、ja 側の変更は (b) のミラーと EN-Revision の更新のみ。 | 内容 | 件数 | |---|---| | `<para>` から `<simpara>` へのミラーと EN-Revision の更新 | 32ファイル（49箇所） | | EN-Revision の更新のみ | 13ファイル | 内訳: reference/mysqli 25件 / reference/pdo 18件 / appendices 2件 php/doc-en#5712 の対象のうち、訳文の変更を伴う以下の 7 ファイルは本 PR に 含めていない。 - reference/pdo/constants.xml - reference/mysqli/configure.xml - reference/mysqli/ini.xml - reference/mysqli/quickstart.xml - reference/mysqli/summary.xml - reference/mysqli/mysqli/poll.xml - reference/mysqli/mysqli/stmt-init.xml
2 participants
I tried to fix all grammar issues and typos that failed AI check. Most of the changes are superficial with only a few demanding a bigger rewrite. In particular, reference/mysqli/configure.xml was changed to reflect the up-to-date status.